Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Directory.Build.props #3215

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Add Directory.Build.props #3215

merged 8 commits into from
Feb 4, 2025

Conversation

Saibamen
Copy link
Contributor

Reduce csproj size

@marticliment
Copy link
Owner

Does dotnet build and dotnet publish still work? I had issues in the past with .prop files and the dotnet command...

@Saibamen
Copy link
Contributor Author

Does dotnet build and dotnet publish still work?

dotnet build - yes -> see GH Actions.
dotnet publish - don't know. You can add dotnet publish command to GH Actions (but IMO after dotnet test command)

@Saibamen
Copy link
Contributor Author

FYI: I added dotnet publish --configuration Release --no-restore command to GH Actions in this PR

@Saibamen
Copy link
Contributor Author

@marticliment: ping

@marticliment
Copy link
Owner

Sorry, I haven't had the time to check it yet

@Saibamen Saibamen mentioned this pull request Feb 4, 2025
Merged
@marticliment marticliment merged commit e77661c into marticliment:main Feb 4, 2025
2 checks passed
@Saibamen Saibamen deleted the directory_build_props branch February 4, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marticliment marticliment marticliment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saibamen @marticliment